Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform_docs): Suppress redundant warnings pop-ups introduced in v1.92.2 #700

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

MaxymVlasov
Copy link
Collaborator

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Relates #699

How can we test changes

Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it's Draft PR, it probably still undergos testing, though it technically looks good to me, hence I'm approving it 🤪


if [[ $use_path_to_file ]]; then
common::colorify "yellow" "NOTE: You set both '--hook-config=--path-to-file=' and 'output.file' in '$config_file'"
if [[ $use_path_to_file == true && "$output_file" != "$text_file" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch on a need to check value of the $use_path_to_file var 👍🏻

@MaxymVlasov MaxymVlasov marked this pull request as ready for review August 27, 2024 17:16
@MaxymVlasov MaxymVlasov merged commit 59b2454 into master Aug 27, 2024
5 checks passed
@MaxymVlasov MaxymVlasov deleted the fix/GH-699/findings branch August 27, 2024 17:16
antonbabenko pushed a commit that referenced this pull request Aug 27, 2024
## [1.92.3](v1.92.2...v1.92.3) (2024-08-27)

### Bug Fixes

* **`terraform_docs`:** Suppress redundant warnings pop-ups introduced in v1.92.2 ([#700](#700)) ([59b2454](59b2454))
@antonbabenko
Copy link
Owner

This PR is included in version 1.92.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants